[Mlir-commits] [mlir] [mlir][Transforms][NFC] Dialect conversion: Fix typo and improve docs (PR #107539)

Martin Erhart llvmlistbot at llvm.org
Fri Sep 6 01:14:29 PDT 2024


================
@@ -1130,10 +1130,9 @@ struct ConversionConfig {
   /// builtin.unrealized_conversion_cast ops. The conversion process fails if
   /// at least one materialization could not be built.
   ///
-  /// If set to "false", the dialect conversion does not does not build any
-  /// custom materializations and instead inserts
-  /// builtin.unrealized_conversion_cast ops to ensure that the resulting IR
-  /// is valid.
+  /// If set to "false", the dialect conversion does not build any custom
+  /// materializations and instead inserts builtin.unrealized_conversion_cast
----------------
maerhart wrote:

Nit: maybe wrap the op name in some form of quotation marks?
```suggestion
  /// materializations and instead inserts 'builtin.unrealized_conversion_cast'
```

https://github.com/llvm/llvm-project/pull/107539


More information about the Mlir-commits mailing list