[Mlir-commits] [mlir] [mlir] Add the ability to define dialect-specific location attrs. (PR #105584)

[River Riddle]

River707 wrote:

> OOC could you say more about what didn't fit in the hierachy? (e.g., file is just a reference, so folks have done things like `gpu://0/1`).
> 
> (mentioning another design option rather than critiquing current) Did you consider FusedLoc's metadata?

Haven't looked at the patch deeply yet, but I do kind of agree that opening up the hierarchy is something we should do. I've been thinking about it periodically from time to time for a while, and I don't have a great concrete reason why we shouldn't. I did the FusedLoc+metadata approach at Modular for debug info, and honestly it was kind of a minor convoluted mess trying to reason about this in the IR (for transformation/analysis) and especially reason about it in a consistent way. One other thing I wanted to do at some point was prototype some frontend source locations, but it was kind of weird to fit that prototype location in the fused metadata box.

https://github.com/llvm/llvm-project/pull/105584