[Mlir-commits] [mlir] [mlir] [scf] fix crash when conversion from scf to control flow (PR #107221)

[donald chen]

cxy-1993 wrote:

Thank you for pointing that out. I hadn't noticed the difference between conversion patterns and rewrite patterns before. 

But in the above case, we're just chaining the affine->scf and scf->cf rewrite patterns together without mixing them with other conversion patterns. Furthermore, these patterns already use partial conversion (lower-affine, scf-to-cf). Does this mean that using methods like getBody()->getTerminator() is inherently dangerous for all patterns, whether they're conversion patterns or rewrite patterns?

https://github.com/llvm/llvm-project/pull/107221