[Mlir-commits] [clang] [llvm] [mlir] [TableGen] Add const variants of accessors for backend (PR #106658)

Rahul Joshi llvmlistbot at llvm.org
Wed Sep 4 10:42:40 PDT 2024


================
@@ -189,7 +189,7 @@ static StringRef NormalizeGNUAttrSpelling(StringRef AttrSpelling) {
 
 typedef std::vector<std::pair<std::string, const Record *>> ParsedAttrMap;
 
-static ParsedAttrMap getParsedAttrList(const RecordKeeper &Records,
----------------
jurahul wrote:

And here's for the entire MLIR tablegen code: https://github.com/llvm/llvm-project/commit/061076db7f668f67183e813db6d339a840a05414

So may be its not that involved. Note that this does not address all the const correctness issues, as const Record* function may themselves non-const pointers. So that needs to be fixed gradually as well. So I propose we get this commit in, and then the MLIR one as a follow on. I will see if I can do the clang one as well.

https://github.com/llvm/llvm-project/pull/106658


More information about the Mlir-commits mailing list