[Mlir-commits] [mlir] [mlir][vector] Bugfix of linearize `vector.extract` (PR #106836)

[Cullen Rhodes]

================
@@ -337,6 +337,9 @@ struct LinearizeVectorExtract final
   matchAndRewrite(vector::ExtractOp extractOp, OpAdaptor adaptor,
                   ConversionPatternRewriter &rewriter) const override {
     Type dstTy = getTypeConverter()->convertType(extractOp.getType());
----------------
c-rhodes wrote:

given `extractOp.getType()` can be a scalar, I wouldn't be surprised if there was a scalar type that could be converted to some other scalar type by this conversion, and thus not return a null type. It seems a bit flaky to assume this type conversion will fail unless it's an n-D vector type, but I can't seem to break it so I'm going to say it's ok, but I just thought I'd mention as this was pretty confusing to me.

https://github.com/llvm/llvm-project/pull/106836