[Mlir-commits] [mlir] [mlir] Enable decoupling two kinds of greedy behavior. (PR #104649)

[Jacques Pienaar]

jpienaar wrote:

> Is the hasTrait purely the ConstantLike trait check? or cumulative checking for the various operands/etc.? Feels like there is a lot of low hanging fruit here for optimization, even outside of decoupling folding.

Its cumulative. This is across all pass executions for the pipeline, so there are multiple greedy pattern applications along with other passes/walks. There 3 iterations at most for any of them (2 being minimum if mutation is made). Now, this is the entire pipeline so at the start of pipeline there may be some cleanup value. But none of the dialects matched/produced implement folders, so in this pipeline beyond the first pass, making checking for constants cheaper just makes the wasted time lower (it doesn't really have a benefit, disabling it improves compile time significantly with no negative performance impact).

https://github.com/llvm/llvm-project/pull/104649