[Mlir-commits] [mlir] [mlir][AsmPrinter] Print op properties directly in generic form (PR #106996)

Andrei Golubev llvmlistbot at llvm.org
Mon Sep 2 07:22:14 PDT 2024


================
@@ -668,6 +674,13 @@ class RegisteredOperationName : public OperationName {
 
       return {};
     }
+    void printProperties(Operation *op, OpAsmPrinter &printer) final {
+      if constexpr (hasProperties) {
+        auto concreteOp = cast<ConcreteOp>(op);
+        ConcreteOp::printProperties(concreteOp->getContext(), printer,
+                                    concreteOp.getProperties());
----------------
andrey-golubev wrote:

self-review: perhaps I should be explicit here to also pass `ArrayRef<StringRef>{}` as the 4th argument?

https://github.com/llvm/llvm-project/pull/106996


More information about the Mlir-commits mailing list