[Mlir-commits] [mlir] Extend `getBackwardSlice` to track values captured from above (PR #113478)

[Mehdi Amini]

joker-eph wrote:

I reverted because the mlir-nvidia bot was broken:
```
FAILED: lib/libMLIRAnalysis.so.20.0git 
: && /usr/bin/clang++ -fPIC -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -Wundef -Werror=mismatched-tags -Werror=global-constructors -O3 -DNDEBUG  -Wl,-z,defs -Wl,-z,nodelete -fuse-ld=lld -Wl,--color-diagnostics   -Wl,--gc-sections -shared -Wl,-soname,libMLIRAnalysis.so.20.0git -o lib/libMLIRAnalysis.so.20.0git tools/mlir/lib/Analysis/CMakeFiles/obj.MLIRAnalysis.dir/AliasAnalysis.cpp.o tools/mlir/lib/Analysis/CMakeFiles/obj.MLIRAnalysis.dir/CallGraph.cpp.o tools/mlir/lib/Analysis/CMakeFiles/obj.MLIRAnalysis.dir/DataFlowFramework.cpp.o tools/mlir/lib/Analysis/CMakeFiles/obj.MLIRAnalysis.dir/DataLayoutAnalysis.cpp.o tools/mlir/lib/Analysis/CMakeFiles/obj.MLIRAnalysis.dir/FlatLinearValueConstraints.cpp.o tools/mlir/lib/Analysis/CMakeFiles/obj.MLIRAnalysis.dir/Liveness.cpp.o tools/mlir/lib/Analysis/CMakeFiles/obj.MLIRAnalysis.dir/CFGLoopInfo.cpp.o tools/mlir/lib/Analysis/CMakeFiles/obj.MLIRAnalysis.dir/SliceAnalysis.cpp.o tools/mlir/lib/Analysis/CMakeFiles/obj.MLIRAnalysis.dir/SliceWalk.cpp.o tools/mlir/lib/Analysis/CMakeFiles/obj.MLIRAnalysis.dir/TopologicalSortUtils.cpp.o tools/mlir/lib/Analysis/CMakeFiles/obj.MLIRAnalysis.dir/AliasAnalysis/LocalAliasAnalysis.cpp.o tools/mlir/lib/Analysis/CMakeFiles/obj.MLIRAnalysis.dir/DataFlow/ConstantPropagationAnalysis.cpp.o tools/mlir/lib/Analysis/CMakeFiles/obj.MLIRAnalysis.dir/DataFlow/DeadCodeAnalysis.cpp.o tools/mlir/lib/Analysis/CMakeFiles/obj.MLIRAnalysis.dir/DataFlow/DenseAnalysis.cpp.o tools/mlir/lib/Analysis/CMakeFiles/obj.MLIRAnalysis.dir/DataFlow/IntegerRangeAnalysis.cpp.o tools/mlir/lib/Analysis/CMakeFiles/obj.MLIRAnalysis.dir/DataFlow/LivenessAnalysis.cpp.o tools/mlir/lib/Analysis/CMakeFiles/obj.MLIRAnalysis.dir/DataFlow/SparseAnalysis.cpp.o  -Wl,-rpath,"\$ORIGIN/../lib:/vol/worker/mlir-nvidia/mlir-nvidia/llvm.obj/lib:"  lib/libMLIRCallInterfaces.so.20.0git  lib/libMLIRControlFlowInterfaces.so.20.0git  lib/libMLIRDataLayoutInterfaces.so.20.0git  lib/libMLIRInferIntRangeInterface.so.20.0git  lib/libMLIRInferTypeOpInterface.so.20.0git  lib/libMLIRLoopLikeInterface.so.20.0git  lib/libMLIRPresburger.so.20.0git  lib/libMLIRSideEffectInterfaces.so.20.0git  lib/libMLIRViewLikeInterface.so.20.0git  lib/libMLIRFunctionInterfaces.so.20.0git  lib/libMLIRIR.so.20.0git  lib/libMLIRSupport.so.20.0git  lib/libLLVMSupport.so.20.0git  -Wl,-rpath-link,/vol/worker/mlir-nvidia/mlir-nvidia/llvm.obj/lib && :
ld.lld: error: undefined symbol: mlir::visitUsedValuesDefinedAbove(llvm::MutableArrayRef<mlir::Region>, llvm::function_ref<void (mlir::OpOperand*)>)
>>> referenced by SliceAnalysis.cpp
>>>               tools/mlir/lib/Analysis/CMakeFiles/obj.MLIRAnalysis.dir/SliceAnalysis.cpp.o:(getBackwardSliceImpl(mlir::Operation*, llvm::SetVector<mlir::Operation*, llvm::SmallVector<mlir::Operation*, 0u>, llvm::DenseSet<mlir::Operation*, llvm::DenseMapInfo<mlir::Operation*, void> >, 0u>*, mlir::BackwardSliceOptions const&))
```

You should be able to reproduce with `-DBUILD_SHARED_LIBS=ON`

https://github.com/llvm/llvm-project/pull/113478