[Mlir-commits] [mlir] [MLIR][TosaValidation] Enable float element-types on default (PR #114376)

[TatWai Chong]

tatwaichong wrote:

hi @miritb, is there any lit or regresssion test failure related to this in MLIR?

Profile validation should be default off, and should be explicitly turned on for specific profile requirements. Since
- some users want to skip the TOSA validation pass, please see PR 91742.
- why we consider MI the default rather than BI? tosa profile is optional implemented by backends. 
Thus set the profile option to none (Unknown) by default. Does it make sense?

@GeorgeARM 
Currently we don't have full specification compliance option in the validation pass, perhaps it worths to add. 

Can you try to use --tosa-validate="profile=mi" to pass the float types?

https://github.com/llvm/llvm-project/pull/114376