[Mlir-commits] [flang] [llvm] [mlir] [Flang][OpenMP] Update MapInfoFinalization to use BlockArgs Interface and modify use_device_ptr/addr to be order independent (PR #113919)

Sergio Afonso llvmlistbot at llvm.org
Thu Oct 31 07:24:18 PDT 2024


================
@@ -2999,23 +3007,21 @@ convertOmpTargetData(Operation *op, llvm::IRBuilderBase &builder,
       [&moduleTranslation](
           llvm::OpenMPIRBuilder::DeviceInfoTy type,
           llvm::ArrayRef<BlockArgument> blockArgs,
-          llvm::OpenMPIRBuilder::MapValuesArrayTy &basePointers,
-          llvm::OpenMPIRBuilder::MapDeviceInfoArrayTy &devicePointers,
+          llvm::SmallVectorImpl<Value> &devicePtrVars, MapInfoData &mapInfoData,
----------------
skatrak wrote:

Nit: Since it's used for both `use_device_ptr` and `use_device_addr`, to avoid confusion.
```suggestion
          llvm::SmallVectorImpl<Value> &useDeviceVars, MapInfoData &mapInfoData,
```

https://github.com/llvm/llvm-project/pull/113919


More information about the Mlir-commits mailing list