[Mlir-commits] [mlir] [MLIR][Vector] Allow any shaped type to be distributed for vector.wa… (PR #114215)
Renato Golin
llvmlistbot at llvm.org
Thu Oct 31 04:22:54 PDT 2024
rengolin wrote:
> Just translating my objection from the earlier PR to this. It seems wrong to check a verification on `vector` dialect to check that the result is a `shapedtype`. That seems like a layering violation.
Agreed. This could be an interface that both "vector types" implement, and the distribution works on the interface. It would also make it easier to extend other vector types to work in the same way, or change internal behaviour without breaking the distribution.
https://github.com/llvm/llvm-project/pull/114215
More information about the Mlir-commits
mailing list