[Mlir-commits] [mlir] [MLIR][OpenMP] Simplify translation to LLVM IR error handling (PR #114036)

[Sergio Afonso]

skatrak wrote:

> Is the following understanding correct? If so, can you add such explanations to the doxygen?
> 
> This is intended to be the glue between MLIR error API using `llvm::LogicalResult` that is just a flag whether an error occured and LLVM using `llvm::Error`/`llvm::Expected` that additionally also carries the error message itself. Since `LogicialResult` does not contain the error, that API must have already reported the error but still need to pass something as `llvm::Error`, respectively must report the error when converting it to `LogicalResult`.

Yes, that's a pretty good explanation of what this is for. I updated the class description to hopefully capture the need for it a bit better.

https://github.com/llvm/llvm-project/pull/114036