[Mlir-commits] [mlir] [MLIR][OpenMP] Simplify translation to LLVM IR error handling (PR #114036)
Michael Kruse
llvmlistbot at llvm.org
Tue Oct 29 08:23:05 PDT 2024
https://github.com/Meinersbur commented:
Is the following understanding correct? If so, can you add such explanations to the doxygen?
This is intended to be the glue between MLIR error API using `llvm::LogicalResult` that is just a flag whether an error occured and LLVM using `llvm::Error`/`llvm::Expected` that additionally also carries the error message itself. Since `LogicialResult` does not contain the error, that API must have already reported the error but still need to pass something as `llvm::Error`, respectively must report the error when converting it to `LogicalResult`.
https://github.com/llvm/llvm-project/pull/114036
More information about the Mlir-commits
mailing list