[Mlir-commits] [mlir] [MLIR][DLTI] Pretty parsing and printing for DLTI attrs (PR #113365)

Oleksandr Alex Zinenko llvmlistbot at llvm.org
Mon Oct 28 16:16:18 PDT 2024


================
@@ -28,6 +29,123 @@ using namespace mlir;
 
 #define DEBUG_TYPE "dlti"
 
+//===----------------------------------------------------------------------===//
+// parsing
+//===----------------------------------------------------------------------===//
+
+static ParseResult parseKeyValuePair(AsmParser &parser,
----------------
ftynse wrote:

+1, we should document all top-level functions (except may be most simple single-liners, at which point maybe they shouldn't be functions)

https://github.com/llvm/llvm-project/pull/113365


More information about the Mlir-commits mailing list