[Mlir-commits] [mlir] [MLIR, Python] Support converting boolean numpy arrays to and from mlir attributes (PR #113064)

Maksim Levental llvmlistbot at llvm.org
Mon Oct 28 13:01:39 PDT 2024


================
@@ -14,6 +14,7 @@
 #include "llvm/ADT/Twine.h"
 #include "llvm/Support/DataTypes.h"
 
+#include <pybind11/numpy.h>
----------------
makslevental wrote:

nah definitely (as a rule) put `include`s in cpp (ie implementation) unless it's absolutely necessary to put them in the headers. Even then, we often "pre declare" instead of including the header.

https://github.com/llvm/llvm-project/pull/113064


More information about the Mlir-commits mailing list