[Mlir-commits] [mlir] [linalg] Add quantized version of `conv_3d_ncdhw_fcdhw` (PR #113953)

llvmlistbot at llvm.org llvmlistbot at llvm.org
Mon Oct 28 12:29:23 PDT 2024


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {darker}-->


:warning: Python code formatter, darker found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
darker --check --diff -r f0b3b6d15b2c0ee2cff2dd31dc075adb5d9a4ff7...8ff731c832de797c8680b57c94dce67e526d3608 mlir/python/mlir/dialects/linalg/opdsl/ops/core_named_ops.py
``````````

</details>

<details>
<summary>
View the diff from darker here.
</summary>

``````````diff
--- core_named_ops.py	2024-10-28 19:22:23.000000 +0000
+++ core_named_ops.py	2024-10-28 19:28:52.279093 +0000
@@ -1124,10 +1124,11 @@
             D.oh * S.SH + D.kh * S.DH,
             D.ow * S.SW + D.kw * S.DW,
         ],
     ) * TypeFn.cast_signed(U, K[D.f, D.c, D.kd, D.kh, D.kw])
 
+
 @linalg_structured_op
 def conv_3d_ncdhw_fcdhw_q(
     I=TensorDef(
         T1,
         S.N,
@@ -1150,20 +1151,21 @@
     point offsets common to quantized operations.
     """
     implements(ConvolutionOpInterface)
     domain(D.n, D.od, D.oh, D.ow, D.f, D.kd, D.kh, D.kw, D.c)
     O[D.n, D.f, D.od, D.oh, D.ow] += (
-            TypeFn.cast_signed(
+        TypeFn.cast_signed(
             U,
             I[
                 D.n,
                 D.c,
                 D.od * S.SD + D.kd * S.DD,
                 D.oh * S.SH + D.kh * S.DH,
                 D.ow * S.SW + D.kw * S.DW,
             ],
-        ) - TypeFn.cast_signed(U, IZp)
+        )
+        - TypeFn.cast_signed(U, IZp)
     ) * (
         TypeFn.cast_signed(U, K[D.f, D.c, D.kd, D.kh, D.kw])
         - TypeFn.cast_signed(U, KZp)
     )
 

``````````

</details>


https://github.com/llvm/llvm-project/pull/113953


More information about the Mlir-commits mailing list