[Mlir-commits] [mlir] [mlir] fix Undefined behavior in CastInfo::castFailed with From=<MLIRinterface> (PR #87145)

River Riddle llvmlistbot at llvm.org
Mon Oct 28 09:53:21 PDT 2024


================
@@ -521,6 +521,8 @@ class ParentClass {
   /// Write the parent class declaration.
   void writeTo(raw_indented_ostream &os) const;
 
+  friend class OpClass;
+
----------------
River707 wrote:

Can you expose a `getTemplateParams` instead of using friend? Adding a friend in this case feels like a layering violation

https://github.com/llvm/llvm-project/pull/87145


More information about the Mlir-commits mailing list