[Mlir-commits] [mlir] [mlir] add tensor_static.extract/insert to take only static indices. (PR #110550)

[Stella Laurenzo]

https://github.com/stellaraccident commented:

Thanks for the patch. The implementation looks ok, but I think this needs more discussion about how to handle it with respect to the "non static" variants. Otherwise, this becomes an island and all optimizations/lowerings will end up duplicating.

We have other places that have been optimized in this way to allow mixed SSA and attribute indexing. It feels like that is where this needs to go vs having a static variant of all of the ops.

https://github.com/llvm/llvm-project/pull/110550