[Mlir-commits] [mlir] [mlir] Fix bug in UnPackOp tiling implementation causing infinite loop (PR #113571)
Han-Chung Wang
llvmlistbot at llvm.org
Thu Oct 24 16:05:41 PDT 2024
================
@@ -554,13 +554,14 @@ struct UnPackOpTiling
sliceSrcIndices.append(numInnerTiles, zeroAttr);
sliceSrcSizes.append(unpackOp.getMixedTiles());
sliceSrcStrides.append(numInnerTiles, oneAttr);
- Value sliceSource =
+ SmallVector<Operation *> generatedSlices;
+ ExtractSliceOp sliceSource =
b.create<ExtractSliceOp>(loc, unpackOp.getSource(), sliceSrcIndices,
sliceSrcSizes, sliceSrcStrides);
+ generatedSlices.push_back(sliceSource);
----------------
hanhanW wrote:
According to the the doc, we should return the slices for fusion, so it looks like the change makes sense. Why do you think that we should not do this?
```
/// - `generatedSlices` contains the list of slices that are generated during
/// tiling. These slices can be used for fusing producers.
```
https://github.com/llvm/llvm-project/pull/113571
More information about the Mlir-commits
mailing list