[Mlir-commits] [mlir] [MLIR] VectorEmulateNarrowType to support loading of unaligned vectors (PR #113411)

Han-Chung Wang llvmlistbot at llvm.org
Thu Oct 24 12:57:31 PDT 2024


================
@@ -67,6 +69,10 @@ static FailureOr<Operation *> getCompressedMaskOp(OpBuilder &rewriter,
   shape.back() = numElements;
   auto newMaskType = VectorType::get(shape, rewriter.getI1Type());
   if (createMaskOp) {
+    if (frontOffset != 0) {
+      assert(false && "unimplemented case for frontOffset != 0");
----------------
hanhanW wrote:

I think we should not have an assertion here because it is a valid IR and the patterns should be able to handle the failure, which recovers the IR? (My point is that the program should not crash because of it.)

https://github.com/llvm/llvm-project/pull/113411


More information about the Mlir-commits mailing list