[Mlir-commits] [llvm] [mlir] Fix LLVM_ENABLE_ABI_BREAKING_CHECKS macro check: use #if instead of #ifdef (PR #110185)

Dimitry Andric llvmlistbot at llvm.org
Thu Oct 24 09:50:45 PDT 2024


DimitryAndric wrote:

> What « fix » do you refer to for another day?

Sorry, I meant that if the combination of NDEBUG and LLVM_ENABLE_ABI_BREAKING_CHECKS does not make sense, we could adjust the CMake files for that, and get rid of the FORCE_ON and FORCE_OFF settings, only ever enabling LLVM_ENABLE_ABI_BREAKING_CHECKS if NDEBUG is not enabled. Then you could get rid of the NDEBUG checks here.

https://github.com/llvm/llvm-project/pull/110185


More information about the Mlir-commits mailing list