[Mlir-commits] [mlir] [MLIR] Add missing MLIRLLVMDialect dep to MLIRControlFlowToSCF (PR #113560)

Markus Böck llvmlistbot at llvm.org
Thu Oct 24 09:41:18 PDT 2024


zero9178 wrote:

> The proper fix would be an interface I think, the commit you mention is using a string to work around, but that looks a bit like a hack to me.

I think you may be mixing the changes done to `SCFToControlFlow` in that PR with the ones in `ControlFlowToSCF`, where the PR only removes the include, nothing else.

Fully agree otherwise. 

https://github.com/llvm/llvm-project/pull/113560


More information about the Mlir-commits mailing list