[Mlir-commits] [mlir] [mlir][LLVM] Add builders for llvm.intr.assume (PR #113317)

Tobias Gysi llvmlistbot at llvm.org
Thu Oct 24 09:07:29 PDT 2024


================
@@ -3438,7 +3438,46 @@ void InlineAsmOp::getEffects(
 void LLVM::AssumeOp::build(OpBuilder &builder, OperationState &state,
                            mlir::Value cond) {
   return build(builder, state, cond, /*op_bundle_operands=*/{},
-               /*op_bundle_tags=*/{});
+               /*op_bundle_tags=*/ArrayAttr{});
+}
+
+void LLVM::AssumeOp::build(
+    OpBuilder &builder, OperationState &state, mlir::Value cond,
----------------
gysit wrote:

```suggestion
    OpBuilder &builder, OperationState &state, Value cond,
```
nit: I am not sure why the existing builder prefixes Value with mlir:: but there is a using namespace mlir at the top of the file so this can be removed here and below.

https://github.com/llvm/llvm-project/pull/113317


More information about the Mlir-commits mailing list