[Mlir-commits] [mlir] [mlir][LLVM] Add builders for llvm.intr.assume (PR #113317)

Tobias Gysi llvmlistbot at llvm.org
Thu Oct 24 09:07:28 PDT 2024


https://github.com/gysit approved this pull request.

LGTM once the comments are addressed. 

A low-tech alternative maybe to just define some static getters in the extraClassDeclaration that return the tag strings (e.g. static StringRef getAlignTag() / static StringRef getSeparateStorageTag()) and then have one builder that takes a StringRef and a ValueRange. However, that way there may be a mismatch between tag and the number of arguments. I am fine with both approaches!

https://github.com/llvm/llvm-project/pull/113317


More information about the Mlir-commits mailing list