[Mlir-commits] [mlir] [MLIR][Tensor] Fix Chained tensor.cast canonicalization pattern (PR #113551)

Prashant Kumar llvmlistbot at llvm.org
Thu Oct 24 06:30:48 PDT 2024


pashu123 wrote:

> > Do we want to add a test case for this? Maybe something like `func @chained_wrong_tensor_cast_avoid_crash`.
> 
> I did try to add that, but as I mentioned in the commit that such a case would be cast incompatible, hence it fails during the verify stage itself, it didn't even go into that code.

You can add a test case disabling the verifier, i.e., with `verify-each=0`, but I am unsure whether we want to do that. Maybe @MaheshRavishankar or @joker-eph would comment more on this.

https://github.com/llvm/llvm-project/pull/113551


More information about the Mlir-commits mailing list