[Mlir-commits] [mlir] [mlir] UnsignedWhenEquivalent: use greedy rewriter instead of dialect conversion (PR #112454)

Krzysztof Drewniak llvmlistbot at llvm.org
Wed Oct 23 08:03:34 PDT 2024


================
@@ -29,6 +30,9 @@ using namespace mlir::dataflow;
 /// Succeeds when a value is statically non-negative in that it has a lower
 /// bound on its value (if it is treated as signed) and that bound is
 /// non-negative.
+// TODO: IntegerRangeAnalysis internally assumes index is 64bit and this pattern
----------------
krzysz00 wrote:

I'm not sure this is true - all that `IntegerRangeAnalysis` does is *store* `index` as 64-bit. The implementations for various ops on `index` *ought* to handle both cases - if they don't might be a bug

https://github.com/llvm/llvm-project/pull/112454


More information about the Mlir-commits mailing list