[Mlir-commits] [mlir] [MLIR][DLTI] Pretty parsing and printing for DLTI attrs (PR #113365)

Christian Ulmann llvmlistbot at llvm.org
Wed Oct 23 02:12:44 PDT 2024


================
@@ -790,13 +790,22 @@ mlir::detail::verifyTargetSystemSpec(TargetSystemSpecInterface spec,
   DenseMap<StringAttr, DataLayoutEntryInterface> deviceDescKeys;
   DenseSet<TargetSystemSpecInterface::DeviceID> deviceIDs;
   for (const auto &entry : spec.getEntries()) {
-    TargetDeviceSpecInterface targetDeviceSpec = entry.second;
+    auto targetDeviceSpec =
+        llvm::dyn_cast<TargetDeviceSpecInterface>(entry.getValue());
----------------
Dinistro wrote:

```suggestion
       dyn_cast<TargetDeviceSpecInterface>(entry.getValue());
```

Nit: These casts are re-exported in the mlir namespace.

https://github.com/llvm/llvm-project/pull/113365


More information about the Mlir-commits mailing list