[Mlir-commits] [mlir] [mlir][tensor] Restrict the verifier for tensor.pack/tensor.unpack (PR #113108)
Matthias Springer
llvmlistbot at llvm.org
Tue Oct 22 13:51:37 PDT 2024
================
@@ -3865,22 +3865,15 @@ static LogicalResult commonVerifierPackAndUnPackOp(OpTy packOrUnPack) {
llvm::zip(packedType.getShape().take_back(mixedTiles.size()),
mixedTiles),
[](std::tuple<int64_t, OpFoldResult> it) {
- std::optional<int64_t> constTileSize =
- getConstantIntValue(std::get<1>(it));
int64_t shape = std::get<0>(it);
- if (!constTileSize) {
- // If specified tile size is dynamic, output shape should
- // be dynamic too.
- return ShapedType::isDynamic(shape);
+ if (Attribute attr =
+ llvm::dyn_cast_if_present<Attribute>(std::get<1>(it))) {
+ if (IntegerAttr intAttr = dyn_cast_or_null<IntegerAttr>(attr)) {
----------------
matthias-springer wrote:
I think you can assume that an attribute is always an `IntegerAttr`. That should be verified by the auto-generated verifier.
https://github.com/llvm/llvm-project/pull/113108
More information about the Mlir-commits
mailing list