[Mlir-commits] [mlir] [mlir][LLVM] Add dedicated operations for assume align and separate_storage (PR #113317)

[Tobias Gysi]

https://github.com/gysit commented:

This intrinsic does not exist in LLVM IR right?

LLVM dialect operations usually have a 1:1 mapping to an LLVM IR instruction/intrinsic. There are a few exceptions for example for constants, since they are not instructions in LLVM IR. In these cases we always prefix the operation with `llvm.mlir.` to clarify this operation is special.

So if we add a new intrinsic it should be prefix the new intrinsics with `llvm.intr.mlir.` or similar. However, we need a good argument for this since this contradicts the LLVM dialect rational (see third paragraph of https://mlir.llvm.org/docs/Dialects/LLVM/).

Is your plan to match on these OPs somehow or would it be good enough to have a convenience builder that builds normal assume operations with the specific tags? 

@ftynse what would be your take on adding specialized intrinsics that do not exist in LLVM IR (AFAIK there is no prior art)? 

https://github.com/llvm/llvm-project/pull/113317