[Mlir-commits] [mlir] [mlir][LLVM] Add dedicated operations for assume align and separate_storage (PR #113317)
Benjamin Maxwell
llvmlistbot at llvm.org
Tue Oct 22 07:27:47 PDT 2024
================
@@ -900,8 +924,11 @@ llvm::CallInst *mlir::LLVM::detail::createIntrinsicCall(
}
unsigned opArg = 0;
for (auto &arg : args) {
- if (!arg)
+ if (!arg) {
+ while (opBundleOperandPositionsSet.contains(opArg))
+ ++opArg;
arg = operands[opArg++];
----------------
MacDue wrote:
This while is unnecessary (and a bit confusing):
```suggestion
unsigned argIdx = opArg++;
if (!isOpBundleOperandPosition[opArg])
arg = operands[argIdx];
```
https://github.com/llvm/llvm-project/pull/113317
More information about the Mlir-commits
mailing list