[Mlir-commits] [mlir] [MLIR] Auto generate source location for python bindings (PR #112923)
Guray Ozen
llvmlistbot at llvm.org
Mon Oct 21 02:36:45 PDT 2024
grypp wrote:
I completely agree with you that it’s nearly impossible to automatically set the location for every case. (PR also checks the `python_packages` directory and noticed that there may be another library there, but it doesn't include `mlir/`.)
That said, we could position this PR to benefit basic Python binding users. For advance users, such as with JAX or a custom DSL, they can (and should) set the location themselves. FWIW, the PR doesn't overwrite when `loc != None`. As @matthias-springer mentioned the location must be set in C++ side. But python implicitly set it to unknown.
I’d love to hear your final thoughts on this. I am fine either way.
https://github.com/llvm/llvm-project/pull/112923
More information about the Mlir-commits
mailing list