[Mlir-commits] [mlir] [mlir] Add forall canonicalization to replace constant induction vars (PR #112764)

Mehdi Amini llvmlistbot at llvm.org
Fri Oct 18 13:10:37 PDT 2024


================
@@ -1787,9 +1787,9 @@ struct ForallOpReplaceConstantInductionVar : public OpRewritePattern<ForallOp> {
       }
       rewriter.replaceAllUsesWith(
           iv, getValueOrCreateConstantIndexOp(rewriter, loc, lb));
-      return success();
+      changed = true;
     }
-    return failure();
+    return success(changed);
   }
----------------
joker-eph wrote:

So this patch is NFC? It would help in the future if you tag the PR as such when there is no behavior change :)

https://github.com/llvm/llvm-project/pull/112764


More information about the Mlir-commits mailing list