[Mlir-commits] [mlir] [mlir] Fix TableGen emission for ops without properties (PR #112851)

River Riddle llvmlistbot at llvm.org
Fri Oct 18 10:49:20 PDT 2024


================
@@ -1275,8 +1273,9 @@ static void genAttrParser(AttributeVariable *attr, MethodBody &body,
 // 'prop-dict' dictionary attr.
 static void genParsedAttrPropertiesSetter(OperationFormat &fmt, Operator &op,
                                           OpClass &opClass) {
-  // Not required unless 'prop-dict' is present.
-  if (!fmt.hasPropDict)
+  // Not required unless 'prop-dict' is present or we
+  // are not using properties.
----------------
River707 wrote:

Can you reflow this comment? It doesn't look like it's wrapped at 80

https://github.com/llvm/llvm-project/pull/112851


More information about the Mlir-commits mailing list