[Mlir-commits] [mlir] [MLIR] Make `OneShotModuleBufferize` use `OpInterface` (PR #110322)

[David Spickett]

DavidSpickett wrote:

> This change breaks bufferization of ops that implement the FunctionOpInterface but have a terminator that doesn't have the ReturnLike trait

Linaro's bots have been very behind but we finally noticed that this has caused SME test failures on AArch64.

Last good build: https://lab.llvm.org/staging/#/builders/125/builds/388
First bad: https://lab.llvm.org/staging/#/builders/125/builds/389

```
$ git bisect good
2026501cf107fcb3cbd51026ba25fda3af823941 is the first bad commit
commit 2026501cf107fcb3cbd51026ba25fda3af823941
Author: Tzung-Han Juang <tzunghan.juang at gmail.com>
Date:   Tue Oct 1 09:58:52 2024 -0400

    [MLIR] Make `OneShotModuleBufferize` use `OpInterface` (#110322)

    **Description:**
    This PR replaces a part of `FuncOp` and `CallOp` with
    `FunctionOpInterface` and `CallOpInterface` in `OneShotModuleBufferize`.
    Also fix the error from an integration test in the a previous PR
    attempt. (https://github.com/llvm/llvm-project/pull/107295)
```

This bot is running SME tests using qemu for emulation. Check the cmake stage to see how to enable that. You will need a recent version of qemu-aarch64 installed.

@banach-space I'll leave it to you to to handle, the linked PR may already solve the issue.

https://github.com/llvm/llvm-project/pull/110322