[Mlir-commits] [mlir] [mlir][td] More rename from packPaddings to nofoldFlags (PR #112453)

llvmlistbot at llvm.org llvmlistbot at llvm.org
Tue Oct 15 16:46:06 PDT 2024


https://github.com/yzhang93 created https://github.com/llvm/llvm-project/pull/112453

The pack_paddings attribute has been renamed to nofold_flags in https://github.com/llvm/llvm-project/pull/111036. There are still some `packPadding` remaining unchanged. This PR rename those to keep consistent. 

>From 614dfdaf14c698f2def16f1cac122bf9875afaf2 Mon Sep 17 00:00:00 2001
From: yzhang93 <zhyuhang88 at gmail.com>
Date: Tue, 15 Oct 2024 16:40:44 -0700
Subject: [PATCH] [mlir][td] More rename from packPaddings to nofoldFlags

---
 .../mlir/Dialect/Linalg/TransformOps/LinalgTransformOps.td    | 4 ++--
 mlir/include/mlir/Dialect/Linalg/Transforms/Transforms.h      | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/mlir/include/mlir/Dialect/Linalg/TransformOps/LinalgTransformOps.td b/mlir/include/mlir/Dialect/Linalg/TransformOps/LinalgTransformOps.td
index 98b9151381222d..0915bbde3072b0 100644
--- a/mlir/include/mlir/Dialect/Linalg/TransformOps/LinalgTransformOps.td
+++ b/mlir/include/mlir/Dialect/Linalg/TransformOps/LinalgTransformOps.td
@@ -1055,13 +1055,13 @@ def PadOp : Op<Transform_Dialect, "structured.pad",
     OpBuilder<(ins "Value":$target,
                    "ArrayRef<int64_t>":$paddingDimensions,
                    CArg<"ArrayRef<int64_t>", "{}">:$staticPadToMultipleOf,
-                   CArg<"ArrayRef<int64_t>", "{}">:$packPaddings,
+                   CArg<"ArrayRef<int64_t>", "{}">:$nofoldFlags,
                    CArg<"ArrayRef<Attribute>", "{}">:$transposePaddings,
                    CArg<"StringRef", "::mlir::bufferization::MaterializeInDestinationOp::getOperationName()">:$copyBackOp)>,
     OpBuilder<(ins "Value":$target,
                    "ArrayRef<int64_t>":$paddingDimensions,
                    "ArrayRef<OpFoldResult>":$mixedPadToMultipleOf,
-                   CArg<"ArrayRef<int64_t>", "{}">:$packPaddings,
+                   CArg<"ArrayRef<int64_t>", "{}">:$nofoldFlags,
                    CArg<"ArrayRef<Attribute>", "{}">:$transposePaddings,
                    CArg<"StringRef", "::mlir::bufferization::MaterializeInDestinationOp::getOperationName()">:$copyBackOp)>
   ];
diff --git a/mlir/include/mlir/Dialect/Linalg/Transforms/Transforms.h b/mlir/include/mlir/Dialect/Linalg/Transforms/Transforms.h
index 96e0b3c978d5dc..70b086641bdc18 100644
--- a/mlir/include/mlir/Dialect/Linalg/Transforms/Transforms.h
+++ b/mlir/include/mlir/Dialect/Linalg/Transforms/Transforms.h
@@ -297,7 +297,7 @@ struct LinalgPaddingOptions {
   /// A flag for every operand to mark the PadOp as nofold which enables
   /// packing for statically shaped operands.
   SmallVector<bool> nofoldFlags;
-  LinalgPaddingOptions &setPackPaddings(ArrayRef<bool> pp) {
+  LinalgPaddingOptions &setNofoldFlags(ArrayRef<bool> pp) {
     nofoldFlags.assign(pp.begin(), pp.end());
     return *this;
   }



More information about the Mlir-commits mailing list