[mlir] [MLIR][Vector] Add a missing builder implementation for Vector_WarpEx… (PR #110106)
    Andrzej Warzyński 
    llvmlistbot at llvm.org
       
    Tue Oct 15 01:27:17 PDT 2024
    
    
  
banach-space wrote:
I agree with Ben.
If the builder is not used, it should be deleted rather than implemented. If it is to be added, there should also be examples of it being used (these would demonstrate that this is indeed needed).
As a rule of thumb, we should avoid implementing features that are not used - that's potential maintenance burden. While this is a rather small change, there's just no evidence of anyone needing it. Please correct me if I'm wrong :)
https://github.com/llvm/llvm-project/pull/110106
    
    
More information about the Mlir-commits
mailing list