[Mlir-commits] [clang] [llvm] [mlir] [polly] [NFC] Rename `Intrinsic::getDeclaration` to `getOrInsertDeclaration` (PR #111752)

[Rahul Joshi]

jurahul wrote:

> We have downstream code that used `getDeclaration` and now we have changed to `getOrInsertDeclaration` for all places. My understanding from reading the thread is that `getOrInsertDelcaration` will stay and a new `findDeclaration` will be added temporarily, and it will eventually be changed to the "new" `getDeclaration` withe the new semantic. Do I miss anything there?

Yes, that is the proposed plan, but not yet signed off on by folks. The temporary step is so that other out-of-tree code that uses getDeclaration had ample time window to fail building and moving to getOrInsertDeclaration before the new getDeclaration with new semantics is added.

https://github.com/llvm/llvm-project/pull/111752