[Mlir-commits] [mlir] [mlir][LLVMIR] Add operand bundle support for llvm.intr.assume (PR #112143)

Tobias Gysi llvmlistbot at llvm.org
Mon Oct 14 01:26:21 PDT 2024


================
@@ -1291,8 +1291,10 @@ ModuleImport::convertValues(ArrayRef<llvm::Value *> values) {
 }
 
 LogicalResult ModuleImport::convertIntrinsicArguments(
-    ArrayRef<llvm::Value *> values, ArrayRef<unsigned> immArgPositions,
-    ArrayRef<StringLiteral> immArgAttrNames, SmallVectorImpl<Value> &valuesOut,
+    ArrayRef<llvm::Value *> values, ArrayRef<llvm::OperandBundleUse> opBundles,
+    ArrayRef<unsigned> immArgPositions, ArrayRef<StringLiteral> immArgAttrNames,
+    StringLiteral opBundleSizesAttrName, StringLiteral opBundleTagsAttrName,
----------------
gysit wrote:

Could we use constants for `opBundleSizesAttrName` and `opBundleTagsAttrName`? LLVM dialect defines attribute name constants in `LLVMDialect.td`. 

https://github.com/llvm/llvm-project/pull/112143


More information about the Mlir-commits mailing list