[Mlir-commits] [mlir] [mlir][Transforms] Dialect conversion: add `originalType` param to materializations (PR #112128)

[Markus Böck]

https://github.com/zero9178 approved this pull request.

LGTM now, thank you!

> Ideally, patterns should not call this function at all. It's not really an API violation. I'm just saying that it should not be necessary. The uses that I've seen in upstream MLIR are workarounds around 1:N limitations and they are going to disappear soon.

Once your 1:N changes are merged, I think I'd be absolutely amazing to get rid of the API entirely then. I know at least from my own code and other downstream code that it is used rather defensively. But if it is really not needed then it'd help to conceptually simplify dialect conversion by not making these functions public.

https://github.com/llvm/llvm-project/pull/112128