[Mlir-commits] [mlir] [mlir][spirv] Make gen_spirv_dialect.py more precise when finding inst_category (PR #111777)
Caio Oliveira
llvmlistbot at llvm.org
Thu Oct 10 20:33:34 PDT 2024
https://github.com/cmarcelo updated https://github.com/llvm/llvm-project/pull/111777
>From 7c553c97735fcd31e40a6a40be188405ea759742 Mon Sep 17 00:00:00 2001
From: Caio Oliveira <caio.oliveira at intel.com>
Date: Wed, 9 Oct 2024 16:47:31 -0700
Subject: [PATCH] [mlir][spirv] Make gen_spirv_dialect.py more precise when
finding inst_category
Use a word boundary, current code was currently failing when parsing the
definition of because it would also match `CooperativeMatrixOp` from a
later mention of `SPIRV_KHR_CooperativeMatrixOperandsAttr`.
---
mlir/utils/spirv/gen_spirv_dialect.py | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/mlir/utils/spirv/gen_spirv_dialect.py b/mlir/utils/spirv/gen_spirv_dialect.py
index 6d82c012158196..2fb540ef103250 100755
--- a/mlir/utils/spirv/gen_spirv_dialect.py
+++ b/mlir/utils/spirv/gen_spirv_dialect.py
@@ -979,7 +979,8 @@ def extract_td_op_info(op_def):
# Get instruction category
prefix = "SPIRV_"
inst_category = [
- o[len(prefix) :] for o in re.findall(prefix + r"\w+Op", op_def.split(":", 1)[1])
+ o[len(prefix) :]
+ for o in re.findall(prefix + r"\w+Op\b", op_def.split(":", 1)[1])
]
assert len(inst_category) <= 1, "more than one ops in the same section!"
inst_category = inst_category[0] if len(inst_category) == 1 else "Op"
More information about the Mlir-commits
mailing list