[Mlir-commits] [mlir] 6c398ab - [NFC][mlir][spirv] Fix syntax warnings in gen_spirv_dialect.py (#111775)

[llvmlistbot at llvm.org]

Author: Caio Oliveira
Date: 2024-10-10T21:08:18-04:00
New Revision: 6c398abb75da5413152f97a780ddb3b3b2b6a0b7

URL: https://github.com/llvm/llvm-project/commit/6c398abb75da5413152f97a780ddb3b3b2b6a0b7
DIFF: https://github.com/llvm/llvm-project/commit/6c398abb75da5413152f97a780ddb3b3b2b6a0b7.diff

LOG: [NFC][mlir][spirv] Fix syntax warnings in gen_spirv_dialect.py (#111775)

In the context of regular expressions, Python (used to) gracefully
ignore the escape behavior of `\` in some contexts, e.g. for
representing the regular expression `\w+`. However in newer versions of
Python this now gives a warning in the form

```
SyntaxWarning: invalid escape sequence '\w'
```

Fix by explicitly using raw strings instead.

Added: 
    

Modified: 
    mlir/utils/spirv/gen_spirv_dialect.py

Removed: 
    


################################################################################
diff  --git a/mlir/utils/spirv/gen_spirv_dialect.py b/mlir/utils/spirv/gen_spirv_dialect.py
index 78c1022428d8a1..6d82c012158196 100755
--- a/mlir/utils/spirv/gen_spirv_dialect.py
+++ b/mlir/utils/spirv/gen_spirv_dialect.py
@@ -538,7 +538,7 @@ def gen_instr_coverage_report(path, instructions):
 
     prefix = "def SPIRV_OC_"
     existing_opcodes = [
-        k[len(prefix) :] for k in re.findall(prefix + "\w+", content[1])
+        k[len(prefix) :] for k in re.findall(prefix + r"\w+", content[1])
     ]
     existing_instructions = list(
         filter(lambda inst: (inst["opname"] in existing_opcodes), instructions)
@@ -597,7 +597,7 @@ def update_td_opcodes(path, instructions, filter_list):
     # Extend opcode list with existing list
     prefix = "def SPIRV_OC_"
     existing_opcodes = [
-        k[len(prefix) :] for k in re.findall(prefix + "\w+", content[1])
+        k[len(prefix) :] for k in re.findall(prefix + r"\w+", content[1])
     ]
     filter_list.extend(existing_opcodes)
     filter_list = list(set(filter_list))
@@ -644,7 +644,7 @@ def update_td_enum_attrs(path, operand_kinds, filter_list):
     suffix = "Attr"
     existing_kinds = [
         k[len(prefix) : -len(suffix)]
-        for k in re.findall(prefix + "\w+" + suffix, content[1])
+        for k in re.findall(prefix + r"\w+" + suffix, content[1])
     ]
     filter_list.extend(existing_kinds)
 
@@ -971,7 +971,7 @@ def extract_td_op_info(op_def):
     suffix = "Op"
     opname = [
         o[len(prefix) : -len(suffix)]
-        for o in re.findall(prefix + "\w+" + suffix, op_def)
+        for o in re.findall(prefix + r"\w+" + suffix, op_def)
     ]
     assert len(opname) == 1, "more than one ops in the same section!"
     opname = opname[0]
@@ -979,7 +979,7 @@ def extract_td_op_info(op_def):
     # Get instruction category
     prefix = "SPIRV_"
     inst_category = [
-        o[len(prefix) :] for o in re.findall(prefix + "\w+Op", op_def.split(":", 1)[1])
+        o[len(prefix) :] for o in re.findall(prefix + r"\w+Op", op_def.split(":", 1)[1])
     ]
     assert len(inst_category) <= 1, "more than one ops in the same section!"
     inst_category = inst_category[0] if len(inst_category) == 1 else "Op"