[Mlir-commits] [mlir] [mlir][debug] Support DICommonBlock. (PR #111706)

Abid Qadeer llvmlistbot at llvm.org
Thu Oct 10 04:29:06 PDT 2024


abidh wrote:

> We usually also added LLVM dialect roundtrip tests for such additions. Apart from that, this is LGTM!

Thanks for the review. I was not sure where the round trip test go. But I have added one in `test/Dialect/LLVMIR/debuginfo.mlir`. Please let me know if that works. 

https://github.com/llvm/llvm-project/pull/111706


More information about the Mlir-commits mailing list