[Mlir-commits] [mlir] [mlir][transform] Overhaul `RegionBranchOpInterface` implementations. (PR #111408)

Matthias Springer llvmlistbot at llvm.org
Thu Oct 10 02:59:20 PDT 2024


Ingo =?utf-8?q?Müller?= <ingomueller at google.com>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/111408 at github.com>


================
@@ -104,16 +104,8 @@ transform::AlternativesOp::getEntrySuccessorOperands(RegionBranchPoint point) {
 
 void transform::AlternativesOp::getSuccessorRegions(
     RegionBranchPoint point, SmallVectorImpl<RegionSuccessor> &regions) {
-  for (Region &alternative : llvm::drop_begin(
----------------
matthias-springer wrote:

> Plus there are rules about how to combine the different results yielded by different regions/iterations (though the types always match).

I think that alone is already reason enough to drop the `RegionBranchOpInterface` from `scf.forall`.


https://github.com/llvm/llvm-project/pull/111408


More information about the Mlir-commits mailing list