[Mlir-commits] [mlir] [mlir][llvmir] Added extra builders for CallInstrinsicOp (PR #111664)

Sirui Mu llvmlistbot at llvm.org
Wed Oct 9 19:59:27 PDT 2024


================
@@ -1943,6 +1943,11 @@ def LLVM_CallIntrinsicOp
     attr-dict
   }];
 
+  let builders = [
+    OpBuilder<(ins "Type": $results, "StringAttr":$intrin, "ValueRange":$args)>,
+    OpBuilder<(ins "TypeRange": $results, "StringAttr":$intrin, "ValueRange":$args, "FastmathFlagsAttr":$fastMathFlags)>
+    ];
----------------
Lancern wrote:

Another approach might be adding a unit test under `mlir/unittests/Dialect/LLVMIR`. But it seems like few people ever do this ... Anyway this builder is fairly simple and I believe it should be OK if no reviewers have problems about it.

https://github.com/llvm/llvm-project/pull/111664


More information about the Mlir-commits mailing list