[Mlir-commits] [mlir] [mlir][spirv] Make gen_spirv_dialect.py more precise when finding inst_category (PR #111777)

Caio Oliveira llvmlistbot at llvm.org
Wed Oct 9 18:00:09 PDT 2024


https://github.com/cmarcelo created https://github.com/llvm/llvm-project/pull/111777

Use a word boundary, current code was currently failing when parsing the definition of because it would also match
`CooperativeMatrixOp` from a later mention of
`SPIRV_KHR_CooperativeMatrixOperandsAttr`.

>From e4c0e9d2ef0036773f4edff0058fe21a695ae369 Mon Sep 17 00:00:00 2001
From: Caio Oliveira <caio.oliveira at intel.com>
Date: Wed, 9 Oct 2024 16:47:31 -0700
Subject: [PATCH] [mlir][spirv] Make gen_spirv_dialect.py more precise when
 finding inst_category

Use a word boundary, current code was currently failing when parsing the
definition of because it would also match
`CooperativeMatrixOp` from a later mention of
`SPIRV_KHR_CooperativeMatrixOperandsAttr`.
---
 mlir/utils/spirv/gen_spirv_dialect.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mlir/utils/spirv/gen_spirv_dialect.py b/mlir/utils/spirv/gen_spirv_dialect.py
index 78c1022428d8a1..605812fc1a7e82 100755
--- a/mlir/utils/spirv/gen_spirv_dialect.py
+++ b/mlir/utils/spirv/gen_spirv_dialect.py
@@ -979,7 +979,7 @@ def extract_td_op_info(op_def):
     # Get instruction category
     prefix = "SPIRV_"
     inst_category = [
-        o[len(prefix) :] for o in re.findall(prefix + "\w+Op", op_def.split(":", 1)[1])
+        o[len(prefix) :] for o in re.findall(prefix + r"\w+Op\b", op_def.split(":", 1)[1])
     ]
     assert len(inst_category) <= 1, "more than one ops in the same section!"
     inst_category = inst_category[0] if len(inst_category) == 1 else "Op"



More information about the Mlir-commits mailing list