https://github.com/Dinistro approved this pull request. We usually also added LLVM dialect roundtrip tests for such additions. Apart from that, this is LGTM! https://github.com/llvm/llvm-project/pull/111706