[Mlir-commits] [mlir] [mlir][llvmir] Added extra builders for CallInstrinsicOp (PR #111664)

Tobias Gysi llvmlistbot at llvm.org
Wed Oct 9 05:15:34 PDT 2024


================
@@ -3353,6 +3353,25 @@ struct LLVMOpAsmDialectInterface : public OpAsmDialectInterface {
 };
 } // namespace
 
+//===----------------------------------------------------------------------===//
+// CallIntrinsicOp
+//===----------------------------------------------------------------------===//
+
+void CallIntrinsicOp::build(OpBuilder &builder, OperationState &state,
+                            mlir::TypeRange results, mlir::StringAttr intrin,
+                            mlir::ValueRange args,
+                            mlir::LLVM::FastmathFlagsAttr fastMathFlags) {
+
+  build(builder, state, results, intrin, args, fastMathFlags,
+        llvm::ArrayRef<mlir::ValueRange>{});
----------------
gysit wrote:

```suggestion
        /*op_bundle_operands=*/{});
```
nit: this is the operand bundle argument right? I think it is helpful to comment the default initialized arguments to illustrate what is going on.

https://github.com/llvm/llvm-project/pull/111664


More information about the Mlir-commits mailing list