[Mlir-commits] [mlir] [MLIR] Vector dialect: Address post-merge review comments on #111541 (PR #111552)

[Andrzej Warzyński]

banach-space wrote:

> Regarding the unit strides: Actually I was wrong earlier, as the pattern will match as soon as there is any full-size slice dimension. So I went ahead and added a strided testcase... but then it failed to validate, the validator requiring unit strides. And indeed, this is said in the doc: https://mlir.llvm.org/docs/Dialects/Vector/#vectorextract_strided_slice-vectorextractstridedsliceop :
> 
> > At the moment strides must contain only 1s.
> > However, it sounds possible that strides might become flexible in the future, so to limit the risk of bugs popping up then, I'd like to keep the check, even if it can't be exercised now. That's also in line with other patterns in this file.

Yeah, so much for "strided" in `extract_strided_slice` 😂 Perhaps add a TODO somewhere ("Add a test for non-unit strides once these are supported")?

https://github.com/llvm/llvm-project/pull/111552