[Mlir-commits] [mlir] [mlir][linalg][nfc] Delete references to args_in/args_out (PR #111517)

Javed Absar llvmlistbot at llvm.org
Tue Oct 8 11:31:36 PDT 2024


================
@@ -664,8 +664,6 @@ merged into a single step. Canonicalization removes the clone operation and
 func.func @reuseTarget(%arg0: memref<2xf32>, %result: memref<2xf32>){
   %temp = memref.alloc() : memref<2xf32>
   test.generic {
-    args_in = 1 : i64,
-    args_out = 1 : i64,
----------------
javedabsar1 wrote:

Just deleting will still leave IR incorrect. The IR below should be like (Notice the ins , outs and math.exp, and braces ...

```
    %alloc = memref.alloc() : memref<2xf32>
    linalg.generic {indexing_maps = [#map, #map], iterator_types = ["parallel"]} ins(%arg1 : memref<2xf32>) outs(%alloc : memref<2xf32>) {
    ^bb0(%in: f32, %out: f32):
      %1 = math.exp %in : f32
      linalg.yield %1 : f32
    }
``    

https://github.com/llvm/llvm-project/pull/111517


More information about the Mlir-commits mailing list