[Mlir-commits] [mlir] [MLIR] Vector dialect: Address post-merge review comments on #111541 (PR #111552)

Andrzej Warzyński llvmlistbot at llvm.org
Tue Oct 8 09:22:01 PDT 2024


https://github.com/banach-space commented:

That's true speed of light Benoit, thank you!

I've left two small suggestions here and under #111541 :
* use `CHECK-NEXT`, and 
* skip checking strides altogether). 

LGTM otherwise!

Apologies for being a bit pedantic, especially when it comes to tests. That's after spending quite some quality time with them 😅 These updates are much appreciated 🙏🏻 

https://github.com/llvm/llvm-project/pull/111552


More information about the Mlir-commits mailing list